Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/py: add VMA_AREA_MEMFD constant #2245

Merged
merged 1 commit into from
Aug 18, 2023
Merged

lib/py: add VMA_AREA_MEMFD constant #2245

merged 1 commit into from
Aug 18, 2023

Conversation

rst0git
Copy link
Member

@rst0git rst0git commented Aug 13, 2023

VMA_AREA_MEMFD was introduced with commit 29a1a88. This pull request extends the status map used in CRIT and coredump with the value of this constant to recognise it.

Before:

sudo crit show dump/zdtm/static/maps01/56/1/mm-57.img
...
                {
                    "start": "0x7f224b4d4000",
                    "end": "0x7f224b4d5000",
                    "pgoff": 0,
                    "shmid": 6,
                    "prot": "PROT_READ | PROT_WRITE",
                    "flags": "MAP_SHARED",
                    "status": "VMA_AREA_REGULAR | VMA_FILE_SHARED | 0x4000",
                    "fd": -1,
                    "fdflags": "0x2"
                },

After:

sudo crit show dump/zdtm/static/maps01/56/1/mm-57.img
...
                {
                    "start": "0x7f224b4d4000",
                    "end": "0x7f224b4d5000",
                    "pgoff": 0,
                    "shmid": 6,
                    "prot": "PROT_READ | PROT_WRITE",
                    "flags": "MAP_SHARED",
                    "status": "VMA_AREA_REGULAR | VMA_FILE_SHARED | VMA_AREA_MEMFD",
                    "fd": -1,
                    "fdflags": "0x2"
                },

@rst0git
lib/py: add VMA_AREA_MEMFD constant
6ffb81b 
The VMA_AREA_MEMFD constant was introduced with commit

29a1a88
memfd: add memory mapping support

This patch extends the status map used in CRIT and coredump with the
value of this constant to recognize it.

Signed-off-by: Radostin Stoyanov <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (242de4e) 70.55% compared to head (9e62b8d) 70.66%.
Report is 2 commits behind head on criu-dev.

❗ Current head 9e62b8d differs from pull request most recent head 6ffb81b. Consider uploading reports for the commit 6ffb81b to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##           criu-dev    #2245      +/-   ##
============================================
+ Coverage     70.55%   70.66%   +0.11%     
============================================
  Files           134      133       -1     
  Lines         33304    33312       +8     
============================================
+ Hits          23497    23541      +44     
+ Misses         9807     9771      -36

see 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avagin avagin merged commit e1cda9f into checkpoint-restore:criu-dev Aug 18, 2023
34 of 37 checks passed
@rst0git rst0git deleted the crit-memfd branch August 18, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rst0git @codecov-commenter @avagin